@ebagrenrut Can you please review?

@mcmehrtens I'm pretty sure that I added the cmake dependency because starship relies on the Rust cmake crate, which has a dependency on the cmake command being available. Though it's been a while, I have a vague recollection of running into a build failure via Spack CI as a result of having no cmake command in my build image. So though you will find no CMake-related files in the starship source tree, I suspect that the cmake crate is included because some other crate needs cmake. To confirm that cmake really isn't needed, did you confirm that you could build on a system, or in a container, that does not have CMake available?

In fact, the dependency on the cmake create is I think not even a direct dependency of starship itself, but a dependency of a starship dependency (or at least somewhere in the tree of dependencies that cargo pulls in...).

There are very likely other dependencies missing from the starship Spack package that Spack could fulfill, I just didn't encounter them. Because Spack doesn't fully model Rust-based builds, I don't think we currently have a way to ferret out all of the dependencies without brute-force (and possibly laborious) analysis of the full cargo-based build :/

@mcmehrtens At this point, with Spack develop and the checksummed versions of starship, I'm unable to reproduce any issues with cmake, even when in a container with no cmake (neither from spack, nor from the OS). So I approve of this change.

Thanks!